Skip to content

Conversation

@seaona
Copy link
Member

@seaona seaona commented Oct 30, 2025

Description

Vault Corruption is very flaky. The test fails after we have corrupted the vault and we click on the Critical Button error, as this causes to sometimes close the MM window completely, and then leading then to this error:

NoSuchWindowError: no such window: target window already closed from unknown error: web view not found   (Session info: chrome=126.0.6478.182)  
image

Or this one: NoSuchAlertError: no such alert

image

It seems the issue might be in the button handler, so here I'm adding a flag to ensure the button handler cannot be overwritten: once #errorDisplayed is true, no subsequent calls to displayCriticalError or displayStateCorruptionError will execute.

I suspect this can happen because we are trying to open MM multiple times (with the waitUntil) and some previous call can overwrite that? ---to verify with @davidmurdoch @Gudahtt

It might be better to fully understand what's hanging (if that's the case) that then overrides the handler, though I think the change is safe/won't have unintended consequences

Open in GitHub Codespaces

Changelog

CHANGELOG entry:

Related issues

Fixes: #36916

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Replace polling-based wait with a fixed delay and loading check in the vault-corruption E2E test.

  • Tests (E2E)
    • test/e2e/tests/vault-corruption/vault-corruption.spec.ts
      • Update waitForVaultRestorePage:
        • Remove waitUntil loop that repeatedly navigated and checked window title.
        • Add fixed 10s delay, navigate to PAGES.HOME with waitForControllers: false, then assert .loading-logo is not present.

Written by Cursor Bugbot for commit ef934d2. This will update automatically on new commits. Configure here.

@metamaskbot metamaskbot added the team-qa QA team label Oct 30, 2025
@seaona seaona added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Oct 30, 2025
@github-actions github-actions bot added size-S and removed size-XS labels Oct 30, 2025
@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: c39599c | Date: 10/30/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±39ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 719ms (±36ms) 🟢 | historical mean value: 734ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±13ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 39ms 1.01s 1.31s 1.07s 1.31s
domContentLoaded 719ms 36ms 695ms 979ms 749ms 979ms
firstPaint 77ms 13ms 60ms 180ms 88ms 180ms
firstContentfulPaint 77ms 13ms 60ms 180ms 88ms 180ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [c39599c]
UI Startup Metrics (1276 ± 82 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1276112315398213211424
load109596013387911341238
domContentLoaded108995413327911291231
domInteractive19134652029
firstPaint62273134245011031213
backgroundConnect2312172466234242
firstReactRender27185783143
getState20793112237
initialActions60305615
loadScripts8637281094789061006
setupStore1063241016
numNetworkReqs86245622
BrowserifyPower User HomeuiStartup23121848386564730013865
load1211956199134616981991
domContentLoaded1200946197034016651970
domInteractive50152616461261
firstPaint59890198356610121983
backgroundConnect277222737121265737
firstReactRender28253433134
getState18015422718193227
initialActions13256171056
loadScripts954728154430514031544
setupStore1393061330
numNetworkReqs350174744199571744
WebpackStandard HomeuiStartup8467251117778571051
load63758591477640857
domContentLoaded62957989376635851
domInteractive15115681339
firstPaint20660934202198620
backgroundConnect23115372637
firstReactRender27166483236
getState1252941417
initialActions30183410
loadScripts62557688373633839
setupStore1042231216
numNetworkReqs86306628
WebpackPower User HomeuiStartup16951262247240422302472
load74961012241958851224
domContentLoaded71059810541498571054
domInteractive18133782237
firstPaint43072982324652982
backgroundConnect12613471154169471
firstReactRender24222922529
getState15411021119159211
initialActions1901694316169
loadScripts70559610431458451043
setupStore3262686615268
numNetworkReqs348182587144565587
FirefoxBrowserifyStandard HomeuiStartup14991338189110315501658
load1281114116929413371425
domContentLoaded1281114116929413371424
domInteractive1193733846138204
firstPaint------
backgroundConnect4524150214996
firstReactRender26215862644
getState73324914
initialActions318135
loadScripts1253111516659013151370
setupStore1161621315
numNetworkReqs86275721
BrowserifyPower User HomeuiStartup27452263369147433313691
load14181199174514915421745
domContentLoaded14181198174514915421745
domInteractive19992519103274519
firstPaint------
backgroundConnect19541607178368607
firstReactRender41305595155
getState1487731651163316
initialActions22184294284
loadScripts13711172170213814931702
setupStore34795245795
numNetworkReqs25115044996326449
WebpackStandard HomeuiStartup16701464214013617151972
load14241207189711314651650
domContentLoaded14241207189711314641650
domInteractive1143240668117295
firstPaint------
backgroundConnect5025135216193
firstReactRender3024125123036
getState84274815
initialActions6117619419
loadScripts13931189186511214421621
setupStore15674111537
numNetworkReqs86285724
WebpackPower User HomeuiStartup29472324403052034104030
load16771319212326819632123
domContentLoaded16761318212326819632123
domInteractive19251751176221751
firstPaint------
backgroundConnect23033697218500697
firstReactRender44345775157
getState1569737266178372
initialActions13155142555
loadScripts16161270206225818922062
setupStore4651604476160
numNetworkReqs319164562135468562
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 68 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 10 Bytes (0%)

@github-actions github-actions bot added size-XS and removed size-S labels Oct 31, 2025
@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 28a2036 | Date: 10/31/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±40ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 730ms (±38ms) 🟢 | historical mean value: 725ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±13ms) 🟢 | historical mean value: 76ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 40ms 1.01s 1.33s 1.08s 1.33s
domContentLoaded 730ms 38ms 699ms 1.00s 763ms 1.00s
firstPaint 76ms 13ms 56ms 168ms 84ms 168ms
firstContentfulPaint 76ms 13ms 56ms 168ms 84ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [28a2036]
UI Startup Metrics (1264 ± 80 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1264111214268013171399
load107995012427511321209
domContentLoaded107394512297411261198
domInteractive211486132054
firstPaint65176123944111061201
backgroundConnect2302162678234243
firstReactRender28195073245
getState21871102640
initialActions60355716
loadScripts849730100874904979
setupStore1162531219
numNetworkReqs96337630
BrowserifyPower User HomeuiStartup22821775433773930114337
load1205954208837316702088
domContentLoaded1187948201235416592012
domInteractive281669164569
firstPaint860200208859611652088
backgroundConnect279223779131263779
firstReactRender27234452844
getState17414320613176206
initialActions825112651
loadScripts947727165532614071655
setupStore1192021120
numNetworkReqs344197720194603720
WebpackStandard HomeuiStartup858737111771876996
load63859091260649781
domContentLoaded63058290059643773
domInteractive15124771434
firstPaint18959894167198600
backgroundConnect23125172638
firstReactRender281783103238
getState1362941519
initialActions40153515
loadScripts62758088957641762
setupStore1152131216
numNetworkReqs96348832
WebpackPower User HomeuiStartup17811306244236623292442
load763640106616410241066
domContentLoaded73462810151439481015
domInteractive20134492444
firstPaint43111110363629501036
backgroundConnect13523449156351449
firstReactRender27233842838
getState16113120415163204
initialActions914613646
loadScripts72962610041399361004
setupStore20765162565
numNetworkReqs326197689161544689
FirefoxBrowserifyStandard HomeuiStartup14811274198511515461662
load1254109914998413221402
domContentLoaded1253109914998413221401
domInteractive1223655761138227
firstPaint------
backgroundConnect4326144184878
firstReactRender27225882646
getState74304713
initialActions4175848
loadScripts1227107914248012901364
setupStore137199201228
numNetworkReqs96337728
BrowserifyPower User HomeuiStartup27272303359044131363590
load14441259178114215411781
domContentLoaded14441259178114215411781
domInteractive1699336476240364
firstPaint------
backgroundConnect19838730208353730
firstReactRender38295484454
getState1419920327154203
initialActions2612255518225
loadScripts13871224165712014641657
setupStore28693285993
numNetworkReqs25315546086334460
WebpackStandard HomeuiStartup1605142319449116421808
load1381119516067614281512
domContentLoaded1381119416067614281512
domInteractive1083339061111295
firstPaint------
backgroundConnect4625125205087
firstReactRender322378143274
getState84475713
initialActions4265636
loadScripts1354117715417313951494
setupStore1375391342
numNetworkReqs96347730
WebpackPower User HomeuiStartup27612416338931030463389
load16281368204122218832041
domContentLoaded16271368204122218832041
domInteractive1709845888200458
firstPaint------
backgroundConnect17635626143231626
firstReactRender46321152152115
getState1347919836172198
initialActions722261022
loadScripts15711308200921518292009
setupStore3191102641110
numNetworkReqs25016650587305505
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.59 KiB (0.06%)
  • ui: 451 Bytes (0.01%)
  • common: 5.35 KiB (0.06%)

@seaona seaona changed the title fix: debug fix: debug Vault Corruption Oct 31, 2025
@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: e54c0bc | Date: 10/31/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±44ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 729ms (±40ms) 🟢 | historical mean value: 725ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±13ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 44ms 1.02s 1.33s 1.10s 1.33s
domContentLoaded 729ms 40ms 702ms 994ms 763ms 994ms
firstPaint 78ms 13ms 60ms 192ms 84ms 192ms
firstContentfulPaint 78ms 13ms 60ms 192ms 84ms 192ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [e54c0bc]
UI Startup Metrics (1265 ± 76 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1265111414587613221389
load108296312766911381192
domContentLoaded107595812686811291185
domInteractive201482101846
firstPaint63990127543410961193
backgroundConnect2322182547235245
firstReactRender29195183346
getState23962102946
initialActions70588723
loadScripts850713105370901968
setupStore1162341220
numNetworkReqs96327631
BrowserifyPower User HomeuiStartup22511782466173328024661
load1168941201834115592018
domContentLoaded1158932198133515501981
domInteractive281580184380
firstPaint72519520195469712019
backgroundConnect291221927167289927
firstReactRender25232922629
getState19016230336195303
initialActions62225722
loadScripts904714147127812821471
setupStore1293571135
numNetworkReqs336200695185561695
WebpackStandard HomeuiStartup8957591197849131116
load67460898287673904
domContentLoaded66660297586667892
domInteractive16125081541
firstPaint19963932207188729
backgroundConnect251359102849
firstReactRender27185783336
getState1261931418
initialActions3114249
loadScripts66360097284664881
setupStore1062231316
numNetworkReqs106368832
WebpackPower User HomeuiStartup18291308255237523402552
load76864712031519191203
domContentLoaded71763697998791979
domInteractive221447103347
firstPaint4959311063417951106
backgroundConnect15623497183444497
firstReactRender28243932839
getState16714825025174250
initialActions1311002715100
loadScripts71363396994780969
setupStore2561192827119
numNetworkReqs366230611145595611
FirefoxBrowserifyStandard HomeuiStartup15221284195410015741748
load1292108714777413511433
domContentLoaded1291108714777413511433
domInteractive1193834943127210
firstPaint------
backgroundConnect4527132154879
firstReactRender27215152740
getState74294815
initialActions4213249
loadScripts1264106914577413141409
setupStore178211291340
numNetworkReqs96357828
BrowserifyPower User HomeuiStartup27642349378539530403785
load14651279190516115891905
domContentLoaded14641278190416115891904
domInteractive16610335871232358
firstPaint------
backgroundConnect24949859209330859
firstReactRender41286094860
getState1197120431138204
initialActions16288251388
loadScripts13841195173714715381737
setupStore421295307595
numNetworkReqs26616947280328472
WebpackStandard HomeuiStartup16771486238213417331910
load1434124118189614941605
domContentLoaded1434124018179614941605
domInteractive1073334852112231
firstPaint------
backgroundConnect5227227276193
firstReactRender332382133375
getState9417918913
initialActions41192410
loadScripts1404122216999114621581
setupStore158198201335
numNetworkReqs96296826
WebpackPower User HomeuiStartup28252337396643931103966
load16231370214122218092141
domContentLoaded16231369214122218092141
domInteractive1457626962200269
firstPaint------
backgroundConnect18646607150291607
firstReactRender423073104873
getState1346334864147348
initialActions11188201088
loadScripts15681326190119217651901
setupStore31111133127113
numNetworkReqs25515238680349386
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.59 KiB (0.06%)
  • ui: 451 Bytes (0.01%)
  • common: 5.35 KiB (0.06%)

@seaona seaona changed the title fix: debug Vault Corruption fix: Vault Corruption no such window: target window already closed Oct 31, 2025
@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: d6f2069 | Date: 10/31/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±36ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 724ms (±34ms) 🟢 | historical mean value: 721ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±9ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 36ms 1.01s 1.30s 1.06s 1.30s
domContentLoaded 724ms 34ms 696ms 980ms 745ms 980ms
firstPaint 77ms 9ms 60ms 148ms 84ms 148ms
firstContentfulPaint 77ms 9ms 60ms 148ms 84ms 148ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [d6f2069]
UI Startup Metrics (1243 ± 79 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1243108814607913061373
load106393612157211101190
domContentLoaded105793312067111021184
domInteractive19135291845
firstPaint65688120943110831168
backgroundConnect2282152587231243
firstReactRender27185873043
getState227107142242
initialActions61305720
loadScripts83671699471884965
setupStore1062431016
numNetworkReqs96327630
BrowserifyPower User HomeuiStartup22781801389971132143899
load1186947202336516592023
domContentLoaded1176940199735916461997
domInteractive33151353043135
firstPaint911153203154010102031
backgroundConnect27322363498282634
firstReactRender27243432834
getState18916427728196277
initialActions63143714
loadScripts930713160132213771601
setupStore1493071630
numNetworkReqs330142685199647685
WebpackStandard HomeuiStartup9047751230859211105
load67061598980676924
domContentLoaded66160798177668908
domInteractive16125181541
firstPaint21461972218208666
backgroundConnect26136593150
firstReactRender29184883539
getState1463151722
initialActions4116258
loadScripts65860597075665898
setupStore1152231416
numNetworkReqs96358832
WebpackPower User HomeuiStartup17631329252435421842524
load738650979105846979
domContentLoaded71263895393818953
domInteractive19144082440
firstPaint41065959306694959
backgroundConnect12420418148345418
firstReactRender29244862748
getState16513228131163281
initialActions1617428874
loadScripts70763593889807938
setupStore23752153052
numNetworkReqs314132612151506612
FirefoxBrowserifyStandard HomeuiStartup1447124818089015161576
load1234107514307513091363
domContentLoaded1234107514297513091363
domInteractive1173626542129215
firstPaint------
backgroundConnect4224131184779
firstReactRender25215052635
getState74455716
initialActions41961135
loadScripts1209105613637312831337
setupStore1072421114
numNetworkReqs96326725
BrowserifyPower User HomeuiStartup26502229358040128613580
load13551176161313614551613
domContentLoaded13551176161313614551613
domInteractive15410226854217268
firstPaint------
backgroundConnect21834651177355651
firstReactRender442981124981
getState1207014418134144
initialActions13178181678
loadScripts13081144156612214071566
setupStore30575214275
numNetworkReqs25594525119336525
WebpackStandard HomeuiStartup16801422219214117362022
load14301230186311814661702
domContentLoaded14301230186311814651702
domInteractive1043245653108208
firstPaint------
backgroundConnect5026136205993
firstReactRender382490193883
getState124251291016
initialActions616711414
loadScripts14011211183811314351669
setupStore1376061420
numNetworkReqs96347829
WebpackPower User HomeuiStartup27802308370843229983708
load16011310213120217332131
domContentLoaded16001310213120317322131
domInteractive1468033078215330
firstPaint------
backgroundConnect18832765182239765
firstReactRender403175124675
getState1446839071139390
initialActions711751217
loadScripts15471284190517716871905
setupStore29101142731114
numNetworkReqs25390562122335562
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.59 KiB (0.06%)
  • ui: 451 Bytes (0.01%)
  • common: 5.35 KiB (0.06%)

@github-actions github-actions bot removed the size-XS label Oct 31, 2025
@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 9afd08f | Date: 10/31/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±38ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 721ms (±35ms) 🟢 | historical mean value: 722ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±11ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 38ms 1.01s 1.30s 1.09s 1.30s
domContentLoaded 721ms 35ms 700ms 970ms 772ms 970ms
firstPaint 75ms 11ms 60ms 172ms 84ms 172ms
firstContentfulPaint 75ms 11ms 60ms 172ms 84ms 172ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [9afd08f]
UI Startup Metrics (1315 ± 93 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1315116117669313741451
load111898215218611731266
domContentLoaded110995215158811651257
domInteractive221483112147
firstPaint66690129144511111229
backgroundConnect24222236618245259
firstReactRender3219146183546
getState23895122641
initialActions817012938
loadScripts8757261273899331023
setupStore1264161225
numNetworkReqs96327630
BrowserifyPower User HomeuiStartup22261797393764529903937
load1166936199533215671995
domContentLoaded1157930198933015271989
domInteractive301793214293
firstPaint75520616504589981650
backgroundConnect266221690110247690
firstReactRender27235982659
getState17715125424191254
initialActions934611846
loadScripts915708154629112821546
setupStore1293151231
numNetworkReqs370207697195672697
WebpackStandard HomeuiStartup8757511219848941061
load65059798571656844
domContentLoaded64259197670650833
domInteractive15124261533
firstPaint19658980196191648
backgroundConnect25125692843
firstReactRender291771103338
getState1362741519
initialActions3023347
loadScripts63958896568648821
setupStore1152241319
numNetworkReqs96348832
WebpackPower User HomeuiStartup17381280277744022192777
load76063811591689481159
domContentLoaded72162810011308331001
domInteractive201350113150
firstPaint4746110913678421091
backgroundConnect14112537181385537
firstReactRender26224142741
getState15713418710159187
initialActions819322493
loadScripts716625990126823990
setupStore1363492434
numNetworkReqs340197679161562679
FirefoxBrowserifyStandard HomeuiStartup15251338192311815801805
load1293113815377713491423
domContentLoaded1293113715367713481422
domInteractive1233938949136217
firstPaint------
backgroundConnect4726187225084
firstReactRender26225752639
getState11413317847
initialActions4210146
loadScripts1264111015187213161377
setupStore175228301332
numNetworkReqs96327728
BrowserifyPower User HomeuiStartup29442398433564236174335
load14561286170712615691707
domContentLoaded14551285170612615691706
domInteractive16410826451226264
firstPaint------
backgroundConnect27236942288611942
firstReactRender443168105168
getState14510020629161206
initialActions24299315499
loadScripts13991245162511815321625
setupStore5172275568227
numNetworkReqs267160570117335570
WebpackStandard HomeuiStartup16271421200612616631956
load1386121017409214321561
domContentLoaded1386121017399214311560
domInteractive1063427245107225
firstPaint------
backgroundConnect4827150215388
firstReactRender342380163376
getState11419925817
initialActions6113715411
loadScripts1358118117129214051520
setupStore1377491331
numNetworkReqs96316825
WebpackPower User HomeuiStartup26752207349434729353494
load15531290195617917161956
domContentLoaded15521290195617917151956
domInteractive1408828757184287
firstPaint------
backgroundConnect14648459120263459
firstReactRender422873125073
getState1326720439175204
initialActions1326820968
loadScripts15141264189617316781896
setupStore3582064749206
numNetworkReqs249158507101332507
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.59 KiB (0.06%)
  • ui: 1.02 KiB (0.01%)
  • common: 5.35 KiB (0.06%)

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: f6dfa7a | Date: 10/31/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±48ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 730ms (±44ms) 🟢 | historical mean value: 722ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±14ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 48ms 1.02s 1.40s 1.07s 1.40s
domContentLoaded 730ms 44ms 708ms 1.06s 749ms 1.06s
firstPaint 78ms 14ms 60ms 200ms 88ms 200ms
firstContentfulPaint 78ms 14ms 60ms 200ms 88ms 200ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [f6dfa7a]
UI Startup Metrics (1250 ± 78 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1250109414507813011412
load107092612837711111233
domContentLoaded106491812777611031215
domInteractive201493121846
firstPaint62388128343710821195
backgroundConnect2282142537231242
firstReactRender27195373042
getState2084472335
initialActions61456717
loadScripts842690105376879982
setupStore1172131218
numNetworkReqs96357630
BrowserifyPower User HomeuiStartup21681663442579530154425
load1062841200933414022009
domContentLoaded1053835198733213941987
domInteractive33151153347115
firstPaint73575199853010261998
backgroundConnect29517210862373601086
firstReactRender25214042540
getState17211221926194219
initialActions935613656
loadScripts841660151126211261511
setupStore1183561135
numNetworkReqs315146685207661685
WebpackStandard HomeuiStartup8907721114689211011
load66760891771676839
domContentLoaded65960190870665833
domInteractive171264101543
firstPaint19961911177198628
backgroundConnect24145882838
firstReactRender28177593437
getState1362341620
initialActions3016358
loadScripts65659989869663831
setupStore1151731316
numNetworkReqs96348831
WebpackPower User HomeuiStartup16111227250744222092507
load72960112141879011214
domContentLoaded69059110261427981026
domInteractive191254112954
firstPaint4565810343408021034
backgroundConnect13412535174284535
firstReactRender24213432534
getState15210523223152232
initialActions606816468
loadScripts68558910151397881015
setupStore1851192721119
numNetworkReqs316167628159521628
FirefoxBrowserifyStandard HomeuiStartup14251264179010914781655
load1216109714057712701370
domContentLoaded1216109614057712691369
domInteractive1143731452123253
firstPaint------
backgroundConnect37267094254
firstReactRender25206672543
getState84406814
initialActions3125338
loadScripts1194107213787612441346
setupStore127220211113
numNetworkReqs96358732
BrowserifyPower User HomeuiStartup26612214312525928903125
load14261218181713014801817
domContentLoaded14261218181713014801817
domInteractive1558430359200303
firstPaint------
backgroundConnect18838415124337415
firstReactRender433090174890
getState13210218022143180
initialActions10151121551
loadScripts13561194171912514291719
setupStore31772204772
numNetworkReqs23614432568309325
WebpackStandard HomeuiStartup16071408202013416621955
load13781188177211214431631
domContentLoaded13771188177211214431631
domInteractive1063340658108206
firstPaint------
backgroundConnect49231782555104
firstReactRender332293163173
getState114188251018
initialActions6217518314
loadScripts13501170167810414141545
setupStore137129141233
numNetworkReqs96357729
WebpackPower User HomeuiStartup28462309432561634694325
load15501312202722618152027
domContentLoaded15491312202522618142025
domInteractive1524238692163386
firstPaint------
backgroundConnect2193410802883551080
firstReactRender46321001652100
getState1428620636186206
initialActions2322425812242
loadScripts14991282193120517331931
setupStore4662516681251
numNetworkReqs281104603165438603
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.59 KiB (0.06%)
  • ui: 1.15 KiB (0.02%)
  • common: 5.35 KiB (0.06%)

itsyoboieltr
itsyoboieltr previously approved these changes Oct 31, 2025
@seaona seaona marked this pull request as ready for review October 31, 2025 12:04
@seaona seaona changed the title fix: Vault Corruption no such window: target window already closed fix: Vault Corruption flaky test no such window: target window already closed and NoSuchAlertError: no such alert Oct 31, 2025
@seaona seaona marked this pull request as draft October 31, 2025 13:31
@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: ef934d2 | Date: 10/31/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±38ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 723ms (±35ms) 🟢 | historical mean value: 722ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±11ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 38ms 1.01s 1.31s 1.06s 1.31s
domContentLoaded 723ms 35ms 702ms 977ms 743ms 977ms
firstPaint 77ms 11ms 60ms 168ms 88ms 168ms
firstContentfulPaint 77ms 11ms 60ms 168ms 88ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [ef934d2]
UI Startup Metrics (1267 ± 77 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1267111214577713161401
load108396012777311301225
domContentLoaded107795512697311241216
domInteractive201494121849
firstPaint745157123942711161195
backgroundConnect2302182587234246
firstReactRender29195983444
getState2074982535
initialActions71588820
loadScripts854730104873897994
setupStore1072231117
numNetworkReqs96337630
BrowserifyPower User HomeuiStartup22661825417172331534171
load1182942204037117122040
domContentLoaded1174935203036916972030
domInteractive311590204790
firstPaint821105206659910092066
backgroundConnect267221747125247747
firstReactRender26233122631
getState19216028635220286
initialActions936715767
loadScripts940718168234314361682
setupStore1292541325
numNetworkReqs356188720204698720
WebpackStandard HomeuiStartup8937541167809121102
load66160495572671889
domContentLoaded65359794071665863
domInteractive171269101548
firstPaint21161936217185713
backgroundConnect261268103046
firstReactRender291786103436
getState1272641517
initialActions3118349
loadScripts65059492968662850
setupStore1152031316
numNetworkReqs96358832
WebpackPower User HomeuiStartup15561159225037221312250
load67056810181608731018
domContentLoaded642557954137817954
domInteractive19123593035
firstPaint4019510003045911000
backgroundConnect10719411135251411
firstReactRender25223432634
getState14212417311151173
initialActions11045152445
loadScripts638554947135809947
setupStore23581253181
numNetworkReqs320162703172563703
FirefoxBrowserifyStandard HomeuiStartup1484125518159615531634
load1264108414317013111397
domContentLoaded1263108414317013101397
domInteractive1163525641136199
firstPaint------
backgroundConnect4427156195168
firstReactRender27225882750
getState9418018813
initialActions4229347
loadScripts1236106613996712781364
setupStore137214211214
numNetworkReqs96337729
BrowserifyPower User HomeuiStartup26862267380240429873802
load14091217187915915311879
domContentLoaded14081216187915915311879
domInteractive17310235278249352
firstPaint------
backgroundConnect17844544180362544
firstReactRender463092185192
getState1387719332175193
initialActions15185251085
loadScripts13551189161012214841610
setupStore23661173461
numNetworkReqs23913242989337429
WebpackStandard HomeuiStartup16241439220514716461999
load1379119717019014141586
domContentLoaded1378119617009014131586
domInteractive1063446353114208
firstPaint------
backgroundConnect48241642653122
firstReactRender352282173477
getState84737916
initialActions41183410
loadScripts1350117816758113871548
setupStore16598161454
numNetworkReqs96368731
WebpackPower User HomeuiStartup28212288374446531623744
load16161285198822617881988
domContentLoaded16151285198722617881987
domInteractive1346828763211287
firstPaint------
backgroundConnect21144671208281671
firstReactRender432969125369
getState1457522245191222
initialActions51164716
loadScripts15491242186019317561860
setupStore28793193393
numNetworkReqs290161557135357557
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.59 KiB (0.06%)
  • ui: 926 Bytes (0.01%)
  • common: 5.35 KiB (0.06%)

@seaona seaona closed this Nov 17, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-S team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ci - Vault Corruption - Race condition where page is auto closed after confirming Restore

4 participants